diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2020-02-05 12:32:04 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-02-06 14:28:52 +0100 |
| commit | 263a425a482fc495d6d3f9a29b9103a664c38b69 (patch) | |
| tree | 88d60088f56da62fb5300f3e245cbc5b1999bb02 /drivers/net/ethernet/broadcom/bcmsysport.c | |
| parent | r8169: fix performance regression related to PCIe max read request size (diff) | |
| download | linux-dev-263a425a482fc495d6d3f9a29b9103a664c38b69.tar.xz linux-dev-263a425a482fc495d6d3f9a29b9103a664c38b69.zip | |
net: systemport: Avoid RBUF stuck in Wake-on-LAN mode
After a number of suspend and resume cycles, it is possible for the RBUF
to be stuck in Wake-on-LAN mode, despite the MPD enable bit being
cleared which instructed the RBUF to exit that mode.
Avoid creating that problematic condition by clearing the RX_EN and
TX_EN bits in the UniMAC prior to disable the Magic Packet Detector
logic which is guaranteed to make the RBUF exit Wake-on-LAN mode.
Fixes: 83e82f4c706b ("net: systemport: add Wake-on-LAN support")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bcmsysport.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index f07ac0e0af59..e0611cba87f9 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -2736,6 +2736,9 @@ static int __maybe_unused bcm_sysport_resume(struct device *d) umac_reset(priv); + /* Disable the UniMAC RX/TX */ + umac_enable_set(priv, CMD_RX_EN | CMD_TX_EN, 0); + /* We may have been suspended and never received a WOL event that * would turn off MPD detection, take care of that now */ |