diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2019-02-15 12:16:51 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-02-15 20:37:54 -0800 |
| commit | a40061ea2e39494104602b3048751341bda374a1 (patch) | |
| tree | bb51f6f6369e513ec23c3fb46df3d88ae0c5f665 /drivers/net/ethernet/broadcom/bcmsysport.c | |
| parent | net: dsa: b53: Properly account for VLAN filtering (diff) | |
| download | linux-dev-a40061ea2e39494104602b3048751341bda374a1.tar.xz linux-dev-a40061ea2e39494104602b3048751341bda374a1.zip | |
net: systemport: Fix reception of BPDUs
SYSTEMPORT has its RXCHK parser block that attempts to validate the
packet structures, unfortunately setting the L2 header check bit will
cause Bridge PDUs (BPDUs) to be incorrectly rejected because they look
like LLC/SNAP packets with a non-IPv4 or non-IPv6 Ethernet Type.
Fixes: 4e8aedfe78c7 ("net: systemport: Turn on offloads by default")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bcmsysport.c')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bcmsysport.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index 28c9b0bdf2f6..bc3ac369cbe3 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -134,6 +134,10 @@ static void bcm_sysport_set_rx_csum(struct net_device *dev, priv->rx_chk_en = !!(wanted & NETIF_F_RXCSUM); reg = rxchk_readl(priv, RXCHK_CONTROL); + /* Clear L2 header checks, which would prevent BPDUs + * from being received. + */ + reg &= ~RXCHK_L2_HDR_DIS; if (priv->rx_chk_en) reg |= RXCHK_EN; else |