diff options
| author |   Yuval Mintz <Yuval.Mintz@qlogic.com> | 2016-02-16 18:08:01 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-02-16 20:12:16 -0500 |
| commit | e56270f63529718bed5b9017c98fb355a25e9954 (patch) | |
| tree | cc216c8662dcce12bfed50ca845ba78504945415 /drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | |
| parent | bnx2x: extend DCBx support (diff) | |
| download | linux-dev-e56270f63529718bed5b9017c98fb355a25e9954.tar.xz linux-dev-e56270f63529718bed5b9017c98fb355a25e9954.zip | |
bnx2x: Warn about grc timeouts in register dump
There are several scenarios where taking a register dump from a device
might log benign GRC timeout attentions to system logs.
Most common of those is when taking the dump from a 2-port device.
Sadly, there's no easy way to mask the problematic attentions during the
flow - Changing this behvaior would require a firmware update.
For now, simply warn users to ignore the warnings.
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c index 820b7e04bb5f..85a7800bfc12 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c @@ -981,6 +981,11 @@ static void bnx2x_get_regs(struct net_device *dev, memcpy(p, &dump_hdr, sizeof(struct dump_header)); p += dump_hdr.header_size + 1; + /* This isn't really an error, but since attention handling is going + * to print the GRC timeouts using this macro, we use the same. + */ + BNX2X_ERR("Generating register dump. Might trigger harmless GRC timeouts\n"); + /* Actually read the registers */ __bnx2x_get_regs(bp, p); |