diff options
| author |   Michael Chan <michael.chan@broadcom.com> | 2016-06-06 02:37:14 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-06-07 16:02:03 -0700 |
| commit | b9a8460a08a1e0150073cda3e7a0dd23cb888052 (patch) | |
| tree | 508e0eb7c55991312ce852034c1b3d5fdf418c93 /drivers/net/ethernet/broadcom/bnxt/bnxt.c | |
| parent | rxrpc: fix ptr_ret.cocci warnings (diff) | |
| download | linux-dev-b9a8460a08a1e0150073cda3e7a0dd23cb888052.tar.xz linux-dev-b9a8460a08a1e0150073cda3e7a0dd23cb888052.zip | |
bnxt_en: Fix tx push race condition.
Set the is_push flag in the software BD before the tx data is pushed to
the chip. It is possible to get the tx interrupt as soon as the tx data
is pushed. The tx handler will not handle the event properly if the
is_push flag is not set and it will crash.
Signed-off-by: Michael Chan <michael.chan@broadocm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 72a2efff8e49..4615ed4311e8 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -286,7 +286,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev) cpu_to_le32(DB_KEY_TX_PUSH | DB_LONG_TX_PUSH | prod); txr->tx_prod = prod; + tx_buf->is_push = 1; netdev_tx_sent_queue(txq, skb->len); + wmb(); /* Sync is_push and byte queue before pushing data */ push_len = (length + sizeof(*tx_push) + 7) / 8; if (push_len > 16) { @@ -298,7 +300,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev) push_len); } - tx_buf->is_push = 1; goto tx_done; } |