diff options
| author |   Michael Chan <michael.chan@broadcom.com> | 2017-08-28 13:40:30 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-08-28 16:57:10 -0700 |
| commit | 903649e718f80da2ba4b65a0adf6930219b4b2e5 (patch) | |
| tree | 880db9002dc26dea7cc3977efa84c309e4d9f26b /drivers/net/ethernet/broadcom/bnxt/bnxt.c | |
| parent | bnxt: initialize board_info values with proper enums (diff) | |
| download | linux-dev-903649e718f80da2ba4b65a0adf6930219b4b2e5.tar.xz linux-dev-903649e718f80da2ba4b65a0adf6930219b4b2e5.zip | |
bnxt_en: Improve -ENOMEM logic in NAPI poll loop.
If we cannot allocate RX buffers in the NAPI poll loop when processing
an RX event, the current code does not count that event towards the NAPI
budget. This can cause us to potentially loop forever in NAPI if we
consistently cannot allocate new buffers. Improve it by counting
-ENOMEM event as 1 towards the NAPI budget.
Cc: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Reported-by: Martin KaFai Lau <kafai@fb.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 1afb408798d1..a34fcddbd14c 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -1850,6 +1850,13 @@ static int bnxt_poll_work(struct bnxt *bp, struct bnxt_napi *bnapi, int budget) &event); if (likely(rc >= 0)) rx_pkts += rc; + /* Increment rx_pkts when rc is -ENOMEM to count towards + * the NAPI budget. Otherwise, we may potentially loop + * here forever if we consistently cannot allocate + * buffers. + */ + else if (rc == -ENOMEM) + rx_pkts++; else if (rc == -EBUSY) /* partial completion */ break; } else if (unlikely((TX_CMP_TYPE(txcmp) == |