diff options
| author |   shamir rabinovitch <shamir.rabinovitch@oracle.com> | 2018-12-16 09:01:09 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-12-19 10:27:58 -0800 |
| commit | c75ab8a55ac1083c232e4407f52b0cadae6c1e0e (patch) | |
| tree | e83b619d72b6c229928260b1a9644c79ba08dda5 /drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | |
| parent | net/rds: fix warn in rds_message_alloc_sgs (diff) | |
| download | linux-dev-c75ab8a55ac1083c232e4407f52b0cadae6c1e0e.tar.xz linux-dev-c75ab8a55ac1083c232e4407f52b0cadae6c1e0e.zip | |
net/rds: remove user triggered WARN_ON in rds_sendmsg
per comment from Leon in rdma mailing list
https://lkml.org/lkml/2018/10/31/312 :
Please don't forget to remove user triggered WARN_ON.
https://lwn.net/Articles/769365/
"Greg Kroah-Hartman raised the problem of core kernel API code that will
use WARN_ON_ONCE() to complain about bad usage; that will not generate
the desired result if WARN_ON_ONCE() is configured to crash the machine.
He was told that the code should just call pr_warn() instead, and that
the called function should return an error in such situations. It was
generally agreed that any WARN_ON() or WARN_ON_ONCE() calls that can be
triggered from user space need to be fixed."
in addition harden rds_sendmsg to detect and overcome issues with
invalid sg count and fail the sendmsg.
Suggested-by: Leon Romanovsky <leon@kernel.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: shamir rabinovitch <shamir.rabinovitch@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions