diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2018-06-28 12:31:25 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-06-30 18:46:52 +0900 |
| commit | 5037c6280606396ab4d3065b066d4b574df020dc (patch) | |
| tree | 0c0da461ae41fa5c560b883cc20ae6cfde5b72cd /drivers/net/ethernet/broadcom/cnic.c | |
| parent | atm: iphase: fix a 64 bit bug (diff) | |
| download | linux-dev-5037c6280606396ab4d3065b066d4b574df020dc.tar.xz linux-dev-5037c6280606396ab4d3065b066d4b574df020dc.zip | |
cnic: tidy up a size calculation
Static checkers complain that id_tbl->table points to longs and 4 bytes
is smaller than sizeof(long). But the since other side is dividing by
32 instead of sizeof(long), that means the current code works fine.
Anyway, it's more conventional to use the BITS_TO_LONGS() macro when
we're allocating a bitmap.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/broadcom/cnic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/cnic.c b/drivers/net/ethernet/broadcom/cnic.c index 30273a7717e2..4fd829b5e65d 100644 --- a/drivers/net/ethernet/broadcom/cnic.c +++ b/drivers/net/ethernet/broadcom/cnic.c @@ -660,7 +660,7 @@ static int cnic_init_id_tbl(struct cnic_id_tbl *id_tbl, u32 size, u32 start_id, id_tbl->max = size; id_tbl->next = next; spin_lock_init(&id_tbl->lock); - id_tbl->table = kcalloc(DIV_ROUND_UP(size, 32), 4, GFP_KERNEL); + id_tbl->table = kcalloc(BITS_TO_LONGS(size), sizeof(long), GFP_KERNEL); if (!id_tbl->table) return -ENOMEM; |