diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2015-07-16 15:51:16 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-07-20 20:48:14 -0700 |
| commit | bd4060a6108befd1110a4c6be5544c932895d18d (patch) | |
| tree | 5fc57ddd8579d472bcbfee202e015a3444c7d508 /drivers/net/ethernet/broadcom/genet/bcmgenet.c | |
| parent | net: bcmgenet: Use correct dev_id for free_irq (diff) | |
| download | linux-dev-bd4060a6108befd1110a4c6be5544c932895d18d.tar.xz linux-dev-bd4060a6108befd1110a4c6be5544c932895d18d.zip | |
net: bcmgenet: Power on integrated GPHY in bcmgenet_power_up()
We are currently disabling the GPHY interface during bcmgenet_close(),
and attempting to power it back on during bcmgenet_open(). This works
fine for the first time, because we called bcmgenet_mii_config() which
took care of enabling the interface, however, bcmgenet_power_up() really
needs to power on the GPHY for correctness.
This will be particularly important as we want to move
bcmgenet_mii_probe() down to bcmgenet_open() to avoid seeing the "PHY
already attached" message.
Fixes: a642c4f7906f36 ("net: bcmgenet: power up and down integrated GPHY when unused")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index c634ddbbd21d..2efe72f94869 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -907,6 +907,8 @@ static void bcmgenet_power_up(struct bcmgenet_priv *priv, } bcmgenet_ext_writel(priv, reg, EXT_EXT_PWR_MGMT); + if (mode == GENET_POWER_PASSIVE) + bcmgenet_phy_power_set(priv->dev, true); } /* ioctl handle special commands that are not present in ethtool. */ |