diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2014-07-21 17:42:39 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-07-21 19:49:11 -0700 |
| commit | 240524089d7a5c0396656574e299beb3a55461e3 (patch) | |
| tree | 21f67515090c5233e3480600af7b95aa2f953985 /drivers/net/ethernet/broadcom/genet/bcmmii.c | |
| parent | Merge branch 'bcmgenet-next' (diff) | |
| download | linux-dev-240524089d7a5c0396656574e299beb3a55461e3.tar.xz linux-dev-240524089d7a5c0396656574e299beb3a55461e3.zip | |
net: bcmgenet: only update UMAC_CMD if something changed
The link adjustment callback can be called as frequently as desired
by the PHY library, as such, let's avoid doing a Read/Modify/Write
sequence if nothing changed, since these register accesses can be
expensive.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmmii.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index add8d8596084..b1338c9e8abb 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -136,17 +136,18 @@ static void bcmgenet_mii_setup(struct net_device *dev) /* pause capability */ if (!phydev->pause) cmd_bits |= CMD_RX_PAUSE_IGNORE | CMD_TX_PAUSE_IGNORE; + } + if (status_changed) { reg = bcmgenet_umac_readl(priv, UMAC_CMD); reg &= ~((CMD_SPEED_MASK << CMD_SPEED_SHIFT) | CMD_HD_EN | CMD_RX_PAUSE_IGNORE | CMD_TX_PAUSE_IGNORE); reg |= cmd_bits; bcmgenet_umac_writel(priv, reg, UMAC_CMD); - } - if (status_changed) phy_print_status(phydev); + } } void bcmgenet_mii_reset(struct net_device *dev) |