diff options
| author |   Nicolas Saenz Julienne <nsaenzjulienne@suse.de> | 2020-02-25 14:11:59 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-02-26 17:12:30 -0800 |
| commit | 402482a6a78e5c61d8a2ec6311fc5b4aca392cd6 (patch) | |
| tree | 28bc47fbe8fec85bde81e8661fce2e42a17f424c /drivers/net/ethernet/broadcom/genet | |
| parent | sched: act: count in the size of action flags bitfield (diff) | |
| download | linux-dev-402482a6a78e5c61d8a2ec6311fc5b4aca392cd6.tar.xz linux-dev-402482a6a78e5c61d8a2ec6311fc5b4aca392cd6.zip | |
net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed
Outdated Raspberry Pi 4 firmware might configure the external PHY as
rgmii although the kernel currently sets it as rgmii-rxid. This makes
connections unreliable as ID_MODE_DIS is left enabled. To avoid this,
explicitly clear that bit whenever we don't need it.
Fixes: da38802211cc ("net: bcmgenet: Add RGMII_RXID support")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/genet')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmmii.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 6392a2530183..10244941a7a6 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -294,6 +294,7 @@ int bcmgenet_mii_config(struct net_device *dev, bool init) */ if (priv->ext_phy) { reg = bcmgenet_ext_readl(priv, EXT_RGMII_OOB_CTRL); + reg &= ~ID_MODE_DIS; reg |= id_mode_dis; if (GENET_IS_V1(priv) || GENET_IS_V2(priv) || GENET_IS_V3(priv)) reg |= RGMII_MODE_EN_V123; |