diff options
| author |   Miaoqian Lin <linmq006@gmail.com> | 2021-12-11 14:01:53 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-12-13 14:32:08 +0000 |
| commit | ab8eb798ddabddb2944401bf31ead9671cb97d95 (patch) | |
| tree | 433df149b7f0df623ea6bd9b6a54a7b4f8e2f623 /drivers/net/ethernet/broadcom/genet | |
| parent | net/sched: sch_ets: don't remove idle classes from the round-robin list (diff) | |
| download | linux-dev-ab8eb798ddabddb2944401bf31ead9671cb97d95.tar.xz linux-dev-ab8eb798ddabddb2944401bf31ead9671cb97d95.zip | |
net: bcmgenet: Fix NULL vs IS_ERR() checking
The phy_attach() function does not return NULL. It returns error pointers.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/genet')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmmii.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 5f259641437a..c888ddee1fc4 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -589,9 +589,9 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv) * Internal or external PHY with MDIO access */ phydev = phy_attach(priv->dev, phy_name, pd->phy_interface); - if (!phydev) { + if (IS_ERR(phydev)) { dev_err(kdev, "failed to register PHY device\n"); - return -ENODEV; + return PTR_ERR(phydev); } } else { /* |