aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/broadcom/tg3.c
diff options
context:
space:
mode:
authorJean Sacren <sakiwit@gmail.com>2021-10-06 00:41:20 -0600
committerDavid S. Miller <davem@davemloft.net>2021-10-06 15:17:28 +0100
commitfe5d8bd3d3ea7422b8ae8f1863ac2ab06998947a (patch)
tree7931449b4fd6faceeca92d921795c5e9551dfcf6 /drivers/net/ethernet/broadcom/tg3.c
parentMerge branch 'RTL8366RB-enhancements' (diff)
downloadlinux-dev-fe5d8bd3d3ea7422b8ae8f1863ac2ab06998947a.tar.xz
linux-dev-fe5d8bd3d3ea7422b8ae8f1863ac2ab06998947a.zip
net: tg3: fix obsolete check of !err
The err variable is checked for true or false a few lines above. When !err is checked again, it always evaluates to true. Therefore we should skip this check. We should also group the adjacent statements together for readability. Signed-off-by: Jean Sacren <sakiwit@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
-rw-r--r--drivers/net/ethernet/broadcom/tg3.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index d95b11480865..5a50ea75094f 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -11213,12 +11213,8 @@ static void tg3_reset_task(struct work_struct *work)
}
tg3_netif_start(tp);
-
tg3_full_unlock(tp);
-
- if (!err)
- tg3_phy_start(tp);
-
+ tg3_phy_start(tp);
tg3_flag_clear(tp, RESET_TASK_PENDING);
out:
rtnl_unlock();