diff options
| author |   Guillaume Nault <gnault@redhat.com> | 2022-01-10 14:43:11 +0100 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2022-01-11 20:36:08 -0800 |
| commit | a915deaa9abe4fb3a440312c954253a6a733608e (patch) | |
| tree | fa1f90b29df7e60086a3afb5eb0ab5b48351f172 /drivers/net/ethernet/chelsio/libcxgb | |
| parent | gre: Don't accidentally set RTO_ONLINK in gre_fill_metadata_dst() (diff) | |
| download | linux-dev-a915deaa9abe4fb3a440312c954253a6a733608e.tar.xz linux-dev-a915deaa9abe4fb3a440312c954253a6a733608e.zip | |
libcxgb: Don't accidentally set RTO_ONLINK in cxgb_find_route()
Mask the ECN bits before calling ip_route_output_ports(). The tos
variable might be passed directly from an IPv4 header, so it may have
the last ECN bit set. This interferes with the route lookup process as
ip_route_output_key_hash() interpretes this bit specially (to restrict
the route scope).
Found by code inspection, compile tested only.
Fixes: 804c2f3e36ef ("libcxgb,iw_cxgb4,cxgbit: add cxgb_find_route()")
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/chelsio/libcxgb')
| -rw-r--r-- | drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c b/drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c index d04a6c163445..da8d10475a08 100644 --- a/drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c +++ b/drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.c @@ -32,6 +32,7 @@ #include <linux/tcp.h> #include <linux/ipv6.h> +#include <net/inet_ecn.h> #include <net/route.h> #include <net/ip6_route.h> @@ -99,7 +100,7 @@ cxgb_find_route(struct cxgb4_lld_info *lldi, rt = ip_route_output_ports(&init_net, &fl4, NULL, peer_ip, local_ip, peer_port, local_port, IPPROTO_TCP, - tos, 0); + tos & ~INET_ECN_MASK, 0); if (IS_ERR(rt)) return NULL; n = dst_neigh_lookup(&rt->dst, &peer_ip); |