diff options
| author |   Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com> | 2019-03-20 14:11:04 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-20 16:28:13 -0700 |
| commit | 64447506f152cf0f88a0fc23140ca1c5f7ff34a8 (patch) | |
| tree | 31c141610753eefadcc98592f48d36051353884a /drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | |
| parent | Merge branch 'ks8851-fixes' (diff) | |
| download | linux-dev-64447506f152cf0f88a0fc23140ca1c5f7ff34a8.tar.xz linux-dev-64447506f152cf0f88a0fc23140ca1c5f7ff34a8.zip | |
dpaa2-eth: Fix possible access beyond end of array
Make sure we don't try to enqueue XDP_REDIRECT frames to an
inexistent FQ.
While it is guaranteed not to have more than one queue per core,
having fewer queues than CPUs on an interface is a valid
configuration.
Fixes: d678be1dc1ec ("dpaa2-eth: add XDP_REDIRECT support")
Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c')
| -rw-r--r-- | drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c index 2ba49e959c3f..1a68052abb94 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c @@ -1817,7 +1817,7 @@ static int dpaa2_eth_xdp_xmit_frame(struct net_device *net_dev, dpaa2_fd_set_format(&fd, dpaa2_fd_single); dpaa2_fd_set_ctrl(&fd, FD_CTRL_PTA); - fq = &priv->fq[smp_processor_id()]; + fq = &priv->fq[smp_processor_id() % dpaa2_eth_queue_count(priv)]; for (i = 0; i < DPAA2_ETH_ENQUEUE_RETRIES; i++) { err = priv->enqueue(priv, fq, &fd, 0); if (err != -EBUSY) |