diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2018-03-18 12:49:51 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-18 16:32:47 -0400 |
| commit | a069215cf5985f3aa1bba550264907d6bd05c5f7 (patch) | |
| tree | 41c5c089bd32665acdd3b0c45c2b4c463c780a67 /drivers/net/ethernet/freescale/fec_main.c | |
| parent | vmxnet3: use correct flag to indicate LRO feature (diff) | |
| download | linux-dev-a069215cf5985f3aa1bba550264907d6bd05c5f7.tar.xz linux-dev-a069215cf5985f3aa1bba550264907d6bd05c5f7.zip | |
net: fec: Fix unbalanced PM runtime calls
When unbinding/removing the driver, we will run into the following warnings:
[ 259.655198] fec 400d1000.ethernet: 400d1000.ethernet supply phy not found, using dummy regulator
[ 259.665065] fec 400d1000.ethernet: Unbalanced pm_runtime_enable!
[ 259.672770] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00
[ 259.683062] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: f2:3e:93:b7:29:c1
[ 259.696239] libphy: fec_enet_mii_bus: probed
Avoid these warnings by balancing the runtime PM calls during fec_drv_remove().
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/fec_main.c')
| -rw-r--r-- | drivers/net/ethernet/freescale/fec_main.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 7a7f3a42b2aa..d4604bc8eb5b 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3600,6 +3600,8 @@ fec_drv_remove(struct platform_device *pdev) fec_enet_mii_remove(fep); if (fep->reg_phy) regulator_disable(fep->reg_phy); + pm_runtime_put(&pdev->dev); + pm_runtime_disable(&pdev->dev); if (of_phy_is_fixed_link(np)) of_phy_deregister_fixed_link(np); of_node_put(fep->phy_node); |