diff options
| author |   Fabio Estevam <fabio.estevam@freescale.com> | 2015-08-12 12:10:23 -0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-08-12 16:45:46 -0700 |
| commit | b0c6ce24911fcb64715de9569f0f7b4f54d1d045 (patch) | |
| tree | bdbebab3a7b4d41081d50400b49c730cb11823c4 /drivers/net/ethernet/freescale/fec_main.c | |
| parent | bpf: fix bpf_perf_event_read() loop upper bound (diff) | |
| download | linux-dev-b0c6ce24911fcb64715de9569f0f7b4f54d1d045.tar.xz linux-dev-b0c6ce24911fcb64715de9569f0f7b4f54d1d045.zip | |
net: fec: Remove unneeded use of IS_ERR_VALUE() macro
There is no need to use the IS_ERR_VALUE() macro for checking
the return value from pm_runtime_* functions.
Just do a simple negative test instead.
The semantic patch that makes this change is available
in scripts/coccinelle/api/pm_runtime.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/fec_main.c')
| -rw-r--r-- | drivers/net/ethernet/freescale/fec_main.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index ca792368f5df..d8e07bb7e601 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1779,7 +1779,7 @@ static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum) int ret = 0; ret = pm_runtime_get_sync(dev); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; fep->mii_timeout = 0; @@ -1818,7 +1818,7 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum, int ret = 0; ret = pm_runtime_get_sync(dev); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; fep->mii_timeout = 0; @@ -2870,7 +2870,7 @@ fec_enet_open(struct net_device *ndev) int ret; ret = pm_runtime_get_sync(&fep->pdev->dev); - if (IS_ERR_VALUE(ret)) + if (ret < 0) return ret; pinctrl_pm_select_default_state(&fep->pdev->dev); |