diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2020-01-07 16:11:43 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-01-07 13:46:20 -0800 |
| commit | 0d6e5bfc9c5bc852d240cb35b0d850cdb660c4c9 (patch) | |
| tree | 4ba511f9ce438ef6c649c459a4c8a3cf80440b19 /drivers/net/ethernet/freescale | |
| parent | Merge branch 'Documentation-stmmac-documentation-improvements' (diff) | |
| download | linux-dev-0d6e5bfc9c5bc852d240cb35b0d850cdb660c4c9.tar.xz linux-dev-0d6e5bfc9c5bc852d240cb35b0d850cdb660c4c9.zip | |
enetc: Fix an off by one in enetc_setup_tc_txtime()
The priv->tx_ring[] has 16 elements but only priv->num_tx_rings are
set up, the rest are NULL. This ">" comparison should be ">=" to avoid
a potential crash.
Fixes: 0d08c9ec7d6e ("enetc: add support time specific departure base on the qos etf")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale')
| -rw-r--r-- | drivers/net/ethernet/freescale/enetc/enetc_qos.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c index e910aaf0f5ec..00382b7c5bd8 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c @@ -315,7 +315,7 @@ int enetc_setup_tc_txtime(struct net_device *ndev, void *type_data) tc = qopt->queue; - if (tc < 0 || tc > priv->num_tx_rings) + if (tc < 0 || tc >= priv->num_tx_rings) return -EINVAL; /* Do not support TXSTART and TX CSUM offload simutaniously */ |