diff options
| author |   Fuyun Liang <liangfuyun1@huawei.com> | 2017-11-03 12:18:27 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-11-03 21:36:49 +0900 |
| commit | 3e1a8f10a1375133ea4a943f21138f00b4d06dc2 (patch) | |
| tree | 16004dc915ae11b46633e5ad1fd5addfa302e593 /drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | |
| parent | net: hns3: fix for getting advertised_caps in hns3_get_link_ksettings (diff) | |
| download | linux-dev-3e1a8f10a1375133ea4a943f21138f00b4d06dc2.tar.xz linux-dev-3e1a8f10a1375133ea4a943f21138f00b4d06dc2.zip | |
net: hns3: fix a bug in hns3_driv_to_eth_caps
The value of link_modes.advertising and the value of link_modes.supported
is initialized to zero every time in for loop in hns3_driv_to_eth_caps().
But we just want to set specified bit for them. Initialization is
unnecessary. This patch fixes it.
Fixes: 496d03e (net: hns3: Add Ethtool support to HNS3 driver)
Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Lipeng <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c index 0e10a43e29b3..c7b8ebd14f33 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c @@ -359,17 +359,12 @@ static void hns3_driv_to_eth_caps(u32 caps, struct ethtool_link_ksettings *cmd, if (!(caps & hns3_lm_map[i].hns3_link_mode)) continue; - if (is_advertised) { - ethtool_link_ksettings_zero_link_mode(cmd, - advertising); + if (is_advertised) __set_bit(hns3_lm_map[i].ethtool_link_mode, cmd->link_modes.advertising); - } else { - ethtool_link_ksettings_zero_link_mode(cmd, - supported); + else __set_bit(hns3_lm_map[i].ethtool_link_mode, cmd->link_modes.supported); - } } } |