aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/i40e/i40e_common.c
diff options
context:
space:
mode:
authorGreg Rose <gregory.v.rose@intel.com>2016-04-12 08:30:48 -0700
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2016-04-27 13:05:41 -0700
commitdb0772782f6b99adbd8548e1d3830fe019c9f250 (patch)
treef2de3f3600116086dbcfe155478d65781bb29ee3 /drivers/net/ethernet/intel/i40e/i40e_common.c
parenti40e: Add DeviceID for X722 QSFP+ (diff)
downloadlinux-dev-db0772782f6b99adbd8548e1d3830fe019c9f250.tar.xz
linux-dev-db0772782f6b99adbd8548e1d3830fe019c9f250.zip
i40e: Remove zero check
A mirror rule ID may be zero so do not return invalid parameter when the user passes in a zero value for a rule ID. Change-ID: I261b8c24725ce2c6ed32f859da81093dfcbe2970 Signed-off-by: Greg Rose <gregory.v.rose@intel.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to '')
-rw-r--r--drivers/net/ethernet/intel/i40e/i40e_common.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c
index 1db4790423f1..25872f2012c5 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c
@@ -2668,10 +2668,7 @@ i40e_status i40e_aq_delete_mirrorrule(struct i40e_hw *hw, u16 sw_seid,
u16 *rules_used, u16 *rules_free)
{
/* Rule ID has to be valid except rule_type: INGRESS VLAN mirroring */
- if (rule_type != I40E_AQC_MIRROR_RULE_TYPE_VLAN) {
- if (!rule_id)
- return I40E_ERR_PARAM;
- } else {
+ if (rule_type == I40E_AQC_MIRROR_RULE_TYPE_VLAN) {
/* count and mr_list shall be valid for rule_type INGRESS VLAN
* mirroring. For other rule_type, count and rule_type should
* not matter.