aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/ice/ice.h
diff options
context:
space:
mode:
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>2022-02-16 18:50:46 +0100
committerJakub Kicinski <kuba@kernel.org>2022-02-23 08:04:27 -0800
commit167053f8dd0ed60287858448696b4784d7e1d899 (patch)
tree4cc4c7db171bf68db80a02f856762690fb7cb5a9 /drivers/net/ethernet/intel/ice/ice.h
parentMerge branch 'locked-bridge-ports' (diff)
downloadlinux-dev-167053f8dd0ed60287858448696b4784d7e1d899.tar.xz
linux-dev-167053f8dd0ed60287858448696b4784d7e1d899.zip
net: Correct wrong BH disable in hard-interrupt.
I missed the obvious case where netif_ix() is invoked from hard-IRQ context. Disabling bottom halves is only needed in process context. This ensures that the code remains on the current CPU and that the soft-interrupts are processed at local_bh_enable() time. In hard- and soft-interrupt context this is already the case and the soft-interrupts will be processed once the context is left (at irq-exit time). Disable bottom halves if neither hard-interrupts nor soft-interrupts are disabled. Update the kernel-doc, mention that interrupts must be enabled if invoked from process context. Fixes: baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.") Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> Tested-by: Geert Uytterhoeven <geert@linux-m68k.org> Link: https://lore.kernel.org/r/Yg05duINKBqvnxUc@linutronix.de Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/intel/ice/ice.h')
0 files changed, 0 insertions, 0 deletions