path: root/drivers/net/ethernet/intel/igb/igb_main.c
diff options
authorEric Dumazet <edumazet@google.com>2018-09-21 15:27:43 -0700
committerDavid S. Miller <davem@davemloft.net>2018-09-23 21:55:24 -0700
commit2753166e4be9df4677745a7f7d9d8daa94938a08 (patch)
tree91410368466b1c2a04d6042e8c37b5f582ff9667 /drivers/net/ethernet/intel/igb/igb_main.c
parentfm10k: remove ndo_poll_controller (diff)
ixgb: remove ndo_poll_controller
As diagnosed by Song Liu, ndo_poll_controller() can be very dangerous on loaded hosts, since the cpu calling ndo_poll_controller() might steal all NAPI contexts (for all RX/TX queues of the NIC). This capture can last for unlimited amount of time, since one cpu is generally not able to drain all the queues under load. ixgb uses NAPI for TX completions, so we better let core networking stack call the napi->poll() to avoid the capture. This also removes a problematic use of disable_irq() in a context it is forbidden, as explained in commit af3e0fcf7887 ("8139too: Use disable_irq_nosync() in rtl8139_poll_controller()") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions