diff options
| author |   Minghao Chi <chi.minghao@zte.com.cn> | 2022-03-16 01:24:44 +0000 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2022-03-16 19:31:00 -0700 |
| commit | 571703ff387cf5d2efbeda2674644345fcb3b016 (patch) | |
| tree | 170be4473c3a30e518678d7cabace1515c0611ae /drivers/net/ethernet/marvell/mv643xx_eth.c | |
| parent | net: hns3: Fix spelling mistake "does't" -> "doesn't" (diff) | |
| download | linux-dev-571703ff387cf5d2efbeda2674644345fcb3b016.tar.xz linux-dev-571703ff387cf5d2efbeda2674644345fcb3b016.zip | |
net: mv643xx_eth: undo some opreations in mv643xx_eth_probe
Cannot directly return platform_get_irq return irq, there
are operations that need to be undone.
Fixes: bf2b83425b59 ("net: mv643xx_eth: use platform_get_irq() instead of platform_get_resource()")
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220316012444.2126070-1-chi.minghao@zte.com.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/marvell/mv643xx_eth.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index e6cd4e214d79..5f9ab1842d49 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -3189,8 +3189,10 @@ static int mv643xx_eth_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); - if (WARN_ON(irq < 0)) - return irq; + if (WARN_ON(irq < 0)) { + err = irq; + goto out; + } dev->irq = irq; dev->netdev_ops = &mv643xx_eth_netdev_ops; |