diff options
| author |   Yelena Krivosheev <yelena@marvell.com> | 2017-12-19 17:59:47 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-12-20 12:24:12 -0500 |
| commit | 2eecb2e04abb62ef8ea7b43e1a46bdb5b99d1bf8 (patch) | |
| tree | 766c2a32cebdaec59a4ebfccb266af134374755f /drivers/net/ethernet/marvell/mvneta.c | |
| parent | net: mvneta: use proper rxq_number in loop on rx queues (diff) | |
| download | linux-dev-2eecb2e04abb62ef8ea7b43e1a46bdb5b99d1bf8.tar.xz linux-dev-2eecb2e04abb62ef8ea7b43e1a46bdb5b99d1bf8.zip | |
net: mvneta: eliminate wrong call to handle rx descriptor error
There are few reasons in mvneta_rx_swbm() function when received packet
is dropped. mvneta_rx_error() should be called only if error bit [16]
is set in rx descriptor.
[gregory.clement@free-electrons.com: add fixes tag]
Cc: stable@vger.kernel.org
Fixes: dc35a10f68d3 ("net: mvneta: bm: add support for hardware buffer management")
Signed-off-by: Yelena Krivosheev <yelena@marvell.com>
Tested-by: Dmitri Epshtein <dima@marvell.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/marvell/mvneta.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 1e0835655c93..a539263cd79c 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -1962,9 +1962,9 @@ static int mvneta_rx_swbm(struct mvneta_port *pp, int rx_todo, if (!mvneta_rxq_desc_is_first_last(rx_status) || (rx_status & MVNETA_RXD_ERR_SUMMARY)) { + mvneta_rx_error(pp, rx_desc); err_drop_frame: dev->stats.rx_errors++; - mvneta_rx_error(pp, rx_desc); /* leave the descriptor untouched */ continue; } |