diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2020-01-31 08:02:41 +0300 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2020-02-01 11:32:43 -0800 |
| commit | 08ff78182fa170dbbe1ebf31e798e9340d6802a5 (patch) | |
| tree | 13a9bc3478489b2f40685745aebb4777919e27cb /drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | |
| parent | tcp: clear tp->segs_{in|out} in tcp_disconnect() (diff) | |
| download | linux-dev-08ff78182fa170dbbe1ebf31e798e9340d6802a5.tar.xz linux-dev-08ff78182fa170dbbe1ebf31e798e9340d6802a5.zip | |
octeontx2-pf: Fix an IS_ERR() vs NULL bug
The otx2_mbox_get_rsp() function never returns NULL, it returns error
pointers on error.
Fixes: 34bfe0ebedb7 ("octeontx2-pf: MTU, MAC and RX mode config support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c index 8247d21d0432..b945bd3d5d88 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c @@ -171,9 +171,9 @@ static int otx2_hw_get_mac_addr(struct otx2_nic *pfvf, } msghdr = otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr); - if (!msghdr) { + if (IS_ERR(msghdr)) { otx2_mbox_unlock(&pfvf->mbox); - return -ENOMEM; + return PTR_ERR(msghdr); } rsp = (struct nix_get_mac_addr_rsp *)msghdr; ether_addr_copy(netdev->dev_addr, rsp->mac_addr); |