diff options
| author |   Minghao Chi <chi.minghao@zte.com.cn> | 2022-05-13 08:19:18 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-05-16 11:47:22 +0100 |
| commit | d887ae3247e022183f244cb325dca1dfbd0a9ed0 (patch) | |
| tree | 852905cf4db42ac80acc5ed5c140f3fc396dcde2 /drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | |
| parent | net: wwan: t7xx: Fix return type of t7xx_dl_add_timedout() (diff) | |
| download | linux-dev-d887ae3247e022183f244cb325dca1dfbd0a9ed0.tar.xz linux-dev-d887ae3247e022183f244cb325dca1dfbd0a9ed0.zip | |
octeontx2-pf: Remove unnecessary synchronize_irq() before free_irq()
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c index 53b2706d65a1..f83e5ca632dd 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c @@ -1718,7 +1718,6 @@ err_free_cints: vec = pci_irq_vector(pf->pdev, pf->hw.nix_msixoff + NIX_LF_QINT_VEC_START); otx2_write64(pf, NIX_LF_QINTX_ENA_W1C(0), BIT_ULL(0)); - synchronize_irq(vec); free_irq(vec, pf); err_disable_napi: otx2_disable_napi(pf); @@ -1762,7 +1761,6 @@ int otx2_stop(struct net_device *netdev) vec = pci_irq_vector(pf->pdev, pf->hw.nix_msixoff + NIX_LF_QINT_VEC_START); otx2_write64(pf, NIX_LF_QINTX_ENA_W1C(0), BIT_ULL(0)); - synchronize_irq(vec); free_irq(vec, pf); /* Cleanup CQ NAPI and IRQ */ |