diff options
| author |   Jia-Ju Bai <baijiaju1990@gmail.com> | 2017-12-24 11:54:33 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-01-02 12:27:33 -0500 |
| commit | 75ce7191eac5972405d1752a991bc002c2957b65 (patch) | |
| tree | 600d5cf2574e1e9fd1a463855175d1e91c30c7ea /drivers/net/ethernet/marvell | |
| parent | net: ptr_ring: otherwise safe empty checks can overrun array bounds (diff) | |
| download | linux-dev-75ce7191eac5972405d1752a991bc002c2957b65.tar.xz linux-dev-75ce7191eac5972405d1752a991bc002c2957b65.zip | |
sky2: Replace mdelay with msleep in sky2_vpd_wait
sky2_vpd_wait is not called in an interrupt handler nor holding a spinlock.
The function mdelay in it can be replaced with msleep, to reduce busy wait.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/marvell')
| -rw-r--r-- | drivers/net/ethernet/marvell/sky2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index 9efe1771423c..9fe85300e7b6 100644 --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers/net/ethernet/marvell/sky2.c @@ -4287,7 +4287,7 @@ static int sky2_vpd_wait(const struct sky2_hw *hw, int cap, u16 busy) dev_err(&hw->pdev->dev, "VPD cycle timed out\n"); return -ETIMEDOUT; } - mdelay(1); + msleep(1); } return 0; |