diff options
| author |   Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-16 11:25:04 +0530 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-07-16 12:38:37 -0700 |
| commit | cf36dd2f7793e8b2723e3eca518fff1be840a297 (patch) | |
| tree | 847bce7d5ad9fdc1e1dfed2ffff192350b8bbd02 /drivers/net/ethernet/mediatek | |
| parent | net: ethernet: mscc: ocelot_board: Add of_node_put() before return (diff) | |
| download | linux-dev-cf36dd2f7793e8b2723e3eca518fff1be840a297.tar.xz linux-dev-cf36dd2f7793e8b2723e3eca518fff1be840a297.zip | |
net: ethernet: mediatek: mtk_eth_soc: Add of_node_put() before goto
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a goto from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the goto.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mediatek')
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index b20b3a5a1ebb..c39d7f4ab1d4 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -2548,8 +2548,10 @@ static int mtk_probe(struct platform_device *pdev) continue; err = mtk_add_mac(eth, mac_np); - if (err) + if (err) { + of_node_put(mac_np); goto err_deinit_hw; + } } if (MTK_HAS_CAPS(eth->soc->caps, MTK_SHARED_INT)) { |