diff options
| author |   Benjamin Poirier <bpoirier@suse.com> | 2017-02-06 10:14:31 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-02-07 12:50:43 -0500 |
| commit | bd4ce941c8d5b862b2f83364be5dbe8fc8ab48f8 (patch) | |
| tree | 8ea7e9d7ea1bba5e9f98ed8fdb22a6d9b2e2c67f /drivers/net/ethernet/mellanox/mlx4/en_rx.c | |
| parent | udp: properly cope with csum errors (diff) | |
| download | linux-dev-bd4ce941c8d5b862b2f83364be5dbe8fc8ab48f8.tar.xz linux-dev-bd4ce941c8d5b862b2f83364be5dbe8fc8ab48f8.zip | |
mlx4: Invoke softirqs after napi_reschedule
mlx4 may schedule napi from a workqueue. Afterwards, softirqs are not run
in a deterministic time frame and the following message may be logged:
NOHZ: local_softirq_pending 08
The problem is the same as what was described in commit ec13ee80145c
("virtio_net: invoke softirqs after __napi_schedule") and this patch
applies the same fix to mlx4.
Fixes: 07841f9d94c1 ("net/mlx4_en: Schedule napi when RX buffers allocation fails")
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/en_rx.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c index eac527e25ec9..cc003fdf0ed9 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c @@ -514,8 +514,11 @@ void mlx4_en_recover_from_oom(struct mlx4_en_priv *priv) return; for (ring = 0; ring < priv->rx_ring_num; ring++) { - if (mlx4_en_is_ring_empty(priv->rx_ring[ring])) + if (mlx4_en_is_ring_empty(priv->rx_ring[ring])) { + local_bh_disable(); napi_reschedule(&priv->rx_cq[ring]->napi); + local_bh_enable(); + } } } |