diff options
| author |   Kamal Heib <kamalh@mellanox.com> | 2016-08-29 01:13:48 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-08-28 23:24:15 -0400 |
| commit | bf50082c15eb2bc47d1922e70f424c57f36646d5 (patch) | |
| tree | a84ae34e39dd7d16c5cb1b5afbf17bf352a14a7c /drivers/net/ethernet/mellanox/mlx5/core/en_common.c | |
| parent | net/mlx5e: Add ethtool counter for TX xmit_more (diff) | |
| download | linux-dev-bf50082c15eb2bc47d1922e70f424c57f36646d5.tar.xz linux-dev-bf50082c15eb2bc47d1922e70f424c57f36646d5.zip | |
net/mlx5e: Fix memory leak if refreshing TIRs fails
Free 'in' command object also when mlx5_core_modify_tir fails.
Fixes: 724b2aa15126 ("net/mlx5e: TIRs management refactoring")
Signed-off-by: Kamal Heib <kamalh@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/en_common.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_common.c b/drivers/net/ethernet/mellanox/mlx5/core/en_common.c index 673043ccd76c..9cce153e1035 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_common.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_common.c @@ -139,7 +139,7 @@ int mlx5e_refresh_tirs_self_loopback_enable(struct mlx5_core_dev *mdev) struct mlx5e_tir *tir; void *in; int inlen; - int err; + int err = 0; inlen = MLX5_ST_SZ_BYTES(modify_tir_in); in = mlx5_vzalloc(inlen); @@ -151,10 +151,11 @@ int mlx5e_refresh_tirs_self_loopback_enable(struct mlx5_core_dev *mdev) list_for_each_entry(tir, &mdev->mlx5e_res.td.tirs_list, list) { err = mlx5_core_modify_tir(mdev, tir->tirn, in, inlen); if (err) - return err; + goto out; } +out: kvfree(in); - return 0; + return err; } |