diff options
| author |   Daniel Borkmann <daniel@iogearbox.net> | 2016-11-19 01:45:02 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-11-21 11:25:58 -0500 |
| commit | a055c19be98bc065a4478663ba7f6833693b8958 (patch) | |
| tree | fcf9d814ff191c1963085ac65a97e89dd9572cfe /drivers/net/ethernet/mellanox/mlx5/core/en_main.c | |
| parent | bpf, mlx5: fix various refcount issues in mlx5e_xdp_set (diff) | |
| download | linux-dev-a055c19be98bc065a4478663ba7f6833693b8958.tar.xz linux-dev-a055c19be98bc065a4478663ba7f6833693b8958.zip | |
bpf, mlx5: drop priv->xdp_prog reference on netdev cleanup
mlx5e_xdp_set() is currently the only place where we drop reference on the
prog sitting in priv->xdp_prog when it's exchanged by a new one. We also
need to make sure that we eventually release that reference, for example,
in case the netdev is dismantled, otherwise we leak the program.
Fixes: 86994156c736 ("net/mlx5e: XDP fast RX drop bpf programs support")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index 491cff9cf368..695760878898 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -3705,6 +3705,9 @@ static void mlx5e_nic_cleanup(struct mlx5e_priv *priv) if (MLX5_CAP_GEN(mdev, vport_group_manager)) mlx5_eswitch_unregister_vport_rep(esw, 0); + + if (priv->xdp_prog) + bpf_prog_put(priv->xdp_prog); } static int mlx5e_init_nic_rx(struct mlx5e_priv *priv) |