diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2017-02-03 17:37:03 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-02-06 16:35:12 -0500 |
| commit | 321fa4ffd94e333657e54037d2511c862ec92f6f (patch) | |
| tree | f92da6f4bff94602cadfe8d57d53fd7950c420dd /drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | |
| parent | net-next: treewide use is_vlan_dev() helper function. (diff) | |
| download | linux-dev-321fa4ffd94e333657e54037d2511c862ec92f6f.tar.xz linux-dev-321fa4ffd94e333657e54037d2511c862ec92f6f.zip | |
net/mlx5e: fix another maybe-uninitialized false-positive
In commit abeffce ("net/mlx5e: Fix a -Wmaybe-uninitialized warning"), I fixed a
gcc warning for the ipv4 offload handling. Now we get the same warning for the
added ipv6 support:
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:815:40: warning: 'out_dev' may be used uninitialized in this function [-Wmaybe-uninitialized]
We can apply the same workaround here as well.
Fixes: ce99f6b97fcd ("net/mlx5e: Support SRIOV TC encapsulation offloads for IPv6 tunnels")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index e3cf5f484153..d87a82682cb5 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -731,8 +731,8 @@ static int mlx5e_route_lookup_ipv6(struct mlx5e_priv *priv, int ret; dst = ip6_route_output(dev_net(mirred_dev), NULL, fl6); - if (dst->error) { - ret = dst->error; + ret = dst->error; + if (ret) { dst_release(dst); return ret; } |