diff options
| author |   Fuqian Huang <huangfq.daxian@gmail.com> | 2019-07-15 11:19:11 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-07-15 11:06:27 -0700 |
| commit | 3a5ee3b30126bd7dc5d6299f3a985d4fefcf42c9 (patch) | |
| tree | bc48ce9996493d2db1151e6d200037db8076a69f /drivers/net/ethernet/mellanox/mlxsw | |
| parent | atm: idt77252: Remove call to memset after dma_alloc_coherent (diff) | |
| download | linux-dev-3a5ee3b30126bd7dc5d6299f3a985d4fefcf42c9.tar.xz linux-dev-3a5ee3b30126bd7dc5d6299f3a985d4fefcf42c9.zip | |
ethernet: remove redundant memset
kvzalloc already zeroes the memory during the allocation.
pci_alloc_consistent calls dma_alloc_coherent directly.
In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So the memset after these function is not needed.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlxsw')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/pci.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/pci.c b/drivers/net/ethernet/mellanox/mlxsw/pci.c index 051b19388a81..615455a21567 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/pci.c +++ b/drivers/net/ethernet/mellanox/mlxsw/pci.c @@ -847,7 +847,6 @@ static int mlxsw_pci_queue_init(struct mlxsw_pci *mlxsw_pci, char *mbox, &mem_item->mapaddr); if (!mem_item->buf) return -ENOMEM; - memset(mem_item->buf, 0, mem_item->size); q->elem_info = kcalloc(q->count, sizeof(*q->elem_info), GFP_KERNEL); if (!q->elem_info) { |