diff options
| author |   Jason A. Donenfeld <Jason@zx2c4.com> | 2020-01-08 16:59:08 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-01-08 15:19:55 -0800 |
| commit | 536577f36ff7afd0a0aff4ebef62db8afe6fc904 (patch) | |
| tree | 4b463ad10b83728ca9ab6d5ef5ae5a12356d74f0 /drivers/net/ethernet/myricom | |
| parent | net: sfc: use skb_list_walk_safe helper for gso segments (diff) | |
| download | linux-dev-536577f36ff7afd0a0aff4ebef62db8afe6fc904.tar.xz linux-dev-536577f36ff7afd0a0aff4ebef62db8afe6fc904.zip | |
net: myri10ge: use skb_list_walk_safe helper for gso segments
This is a straight-forward conversion case for the new function, and
while we're at it, we can remove a null write to skb->next by replacing
it with skb_mark_not_on_list.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/myricom')
| -rw-r--r-- | drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c index c979f38a2e0c..2ee0d0be113a 100644 --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c @@ -2892,7 +2892,7 @@ drop: static netdev_tx_t myri10ge_sw_tso(struct sk_buff *skb, struct net_device *dev) { - struct sk_buff *segs, *curr; + struct sk_buff *segs, *curr, *next; struct myri10ge_priv *mgp = netdev_priv(dev); struct myri10ge_slice_state *ss; netdev_tx_t status; @@ -2901,10 +2901,8 @@ static netdev_tx_t myri10ge_sw_tso(struct sk_buff *skb, if (IS_ERR(segs)) goto drop; - while (segs) { - curr = segs; - segs = segs->next; - curr->next = NULL; + skb_list_walk_safe(segs, curr, next) { + skb_mark_not_on_list(curr); status = myri10ge_xmit(curr, dev); if (status != 0) { dev_kfree_skb_any(curr); |