diff options
| author |   Sudarsana Reddy Kalluru <sudarsana.kalluru@cavium.com> | 2018-11-26 02:26:58 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-11-27 16:17:19 -0800 |
| commit | 149d3775f108c9b97f3309891f010b65e912c7b7 (patch) | |
| tree | bb1ff39bb169e01c115f627591d79fd7ad472e0f /drivers/net/ethernet/qlogic/qede/qede_main.c | |
| parent | qed: Display port_id in the UFP debug messages. (diff) | |
| download | linux-dev-149d3775f108c9b97f3309891f010b65e912c7b7.tar.xz linux-dev-149d3775f108c9b97f3309891f010b65e912c7b7.zip | |
qede: Simplify the usage of qede-flags.
The values represented by qede->flags is being used in mixed ways:
1. As 'value' at some places e.g., QEDE_FLAGS_IS_VF usage
2. As bit-mask(value) at some places e.g., QEDE_FLAGS_PTP_TX_IN_PRORGESS
usage.
This implementation pose problems in future when we want to add more flag
values e.g., overlap of the values, overflow of 64-bit storage.
Updated the implementation to go with approach (2) for qede->flags.
Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
Signed-off-by: Ariel Elior <Ariel.Elior@cavium.com>
Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qede/qede_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index 46d0f2eaa0c0..0f1c480759e0 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -1086,7 +1086,7 @@ static int __qede_probe(struct pci_dev *pdev, u32 dp_module, u8 dp_level, } if (is_vf) - edev->flags |= QEDE_FLAG_IS_VF; + set_bit(QEDE_FLAGS_IS_VF, &edev->flags); qede_init_ndev(edev); |