diff options
| author |   Mintz, Yuval <Yuval.Mintz@cavium.com> | 2017-05-21 12:10:55 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-05-21 12:56:53 -0400 |
| commit | 492a1d9811cbd17c833bd0af18bfaff00cd3ac85 (patch) | |
| tree | e88a15381fcdb00d827c2b303f520a3f1c99486f /drivers/net/ethernet/qlogic/qede/qede_main.c | |
| parent | qede: Add missing Status-block free (diff) | |
| download | linux-dev-492a1d9811cbd17c833bd0af18bfaff00cd3ac85.tar.xz linux-dev-492a1d9811cbd17c833bd0af18bfaff00cd3ac85.zip | |
qede: Don't use an internal MAC field
Driver maintains its primary MAC in a private field which
gets updated when ndo_dev_set_mac() gets called.
However, there are flows where the primary MAC of the device can change
without said NDO being called [bond device in TLB mode configuring
slaves' addresses], resulting in a configuration where there's a mismatch
between what's apparent to user [the netdevice's value] and what's
configured in the HW [the private value].
As we don't have any real motivation of maintaining this
private field, simply remove it and start using the netdevice's
field instead.
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qede/qede_main.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index aea9dcfae62a..a66bdfe40e5b 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -1997,9 +1997,6 @@ static int qede_load(struct qede_dev *edev, enum qede_load_mode mode, goto err4; DP_INFO(edev, "Start VPORT, RXQ and TXQ succeeded\n"); - /* Add primary mac and set Rx filters */ - ether_addr_copy(edev->primary_mac, edev->ndev->dev_addr); - /* Program un-configured VLANs */ qede_configure_vlan_filters(edev); |