diff options
| author |   Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> | 2018-02-16 15:56:39 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-02-19 11:17:34 -0500 |
| commit | f57bbaae7271a47dc6486d489c503faeb248b6d5 (patch) | |
| tree | fd1897fae8fb8d7ffea0045290e3b796eaac7095 /drivers/net/ethernet/qualcomm | |
| parent | net: qualcomm: rmnet: Fix warning seen with 64 bit stats (diff) | |
| download | linux-dev-f57bbaae7271a47dc6486d489c503faeb248b6d5.tar.xz linux-dev-f57bbaae7271a47dc6486d489c503faeb248b6d5.zip | |
net: qualcomm: rmnet: Fix possible null dereference in command processing
If a command packet with invalid mux id is received, the packet would
not have a valid endpoint. This invalid endpoint maybe dereferenced
leading to a crash. Identified by manual code inspection.
Fixes: 3352e6c45760 ("net: qualcomm: rmnet: Convert the muxed endpoint to hlist")
Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qualcomm')
| -rw-r--r-- | drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c index 6bc328fb88e1..b0dbca070c00 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c @@ -38,6 +38,11 @@ static u8 rmnet_map_do_flow_control(struct sk_buff *skb, } ep = rmnet_get_endpoint(port, mux_id); + if (!ep) { + kfree_skb(skb); + return RX_HANDLER_CONSUMED; + } + vnd = ep->egress_dev; ip_family = cmd->flow_control.ip_family; |