diff options
| author |   Kai-Heng Feng <kai.heng.feng@canonical.com> | 2018-09-12 14:58:20 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-09-17 18:45:55 -0700 |
| commit | 94235460f9eaefc4f0a3a4a6014fb4c6db4241cc (patch) | |
| tree | a2a40ef88e7520de71e1b243afe2f0bb71c43d35 /drivers/net/ethernet/realtek/r8169.c | |
| parent | Revert "kcm: remove any offset before parsing messages" (diff) | |
| download | linux-dev-94235460f9eaefc4f0a3a4a6014fb4c6db4241cc.tar.xz linux-dev-94235460f9eaefc4f0a3a4a6014fb4c6db4241cc.zip | |
r8169: Align ASPM/CLKREQ setting function with vendor driver
There's a small delay after setting ASPM in vendor drivers, r8101 and
r8168.
In addition, those drivers enable ASPM before ClkReq, also change that
to align with vendor driver.
I haven't seen anything bad becasue of this, but I think it's better to
keep in sync with vendor driver.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/realtek/r8169.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 1d8631303b53..8195b1f5036d 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -4775,12 +4775,14 @@ static void rtl_pcie_state_l2l3_enable(struct rtl8169_private *tp, bool enable) static void rtl_hw_aspm_clkreq_enable(struct rtl8169_private *tp, bool enable) { if (enable) { - RTL_W8(tp, Config2, RTL_R8(tp, Config2) | ClkReqEn); RTL_W8(tp, Config5, RTL_R8(tp, Config5) | ASPM_en); + RTL_W8(tp, Config2, RTL_R8(tp, Config2) | ClkReqEn); } else { RTL_W8(tp, Config2, RTL_R8(tp, Config2) & ~ClkReqEn); RTL_W8(tp, Config5, RTL_R8(tp, Config5) & ~ASPM_en); } + + udelay(10); } static void rtl_hw_start_8168bb(struct rtl8169_private *tp) |