diff options
| author |   Jisheng Zhang <Jisheng.Zhang@synaptics.com> | 2019-05-22 10:05:09 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-05-22 17:27:15 -0700 |
| commit | 49ce881c0d4c4a7a35358d9dccd5f26d0e56fc61 (patch) | |
| tree | 55713e2cbdd2cf67a563d9544145ec39dfcdd2b7 /drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | |
| parent | mISDN: make sure device name is NUL terminated (diff) | |
| download | linux-dev-49ce881c0d4c4a7a35358d9dccd5f26d0e56fc61.tar.xz linux-dev-49ce881c0d4c4a7a35358d9dccd5f26d0e56fc61.zip | |
net: stmmac: fix reset gpio free missing
Commit 984203ceff27 ("net: stmmac: mdio: remove reset gpio free")
removed the reset gpio free, when the driver is unbinded or rmmod,
we miss the gpio free.
This patch uses managed API to request the reset gpio, so that the
gpio could be freed properly.
Fixes: 984203ceff27 ("net: stmmac: mdio: remove reset gpio free")
Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c index bdd351597b55..093a223fe408 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c @@ -267,7 +267,8 @@ int stmmac_mdio_reset(struct mii_bus *bus) of_property_read_u32_array(np, "snps,reset-delays-us", data->delays, 3); - if (gpio_request(data->reset_gpio, "mdio-reset")) + if (devm_gpio_request(priv->device, data->reset_gpio, + "mdio-reset")) return 0; } |