diff options
| author |   Corentin Labbe <clabbe@baylibre.com> | 2019-11-10 11:30:48 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-11-11 14:43:41 -0800 |
| commit | 40a1dcee2d1846a24619fe9ca45c661ca0db7dda (patch) | |
| tree | aaca436b9b9d0b41e38e7ba4027f6a22d217a896 /drivers/net/ethernet/stmicro | |
| parent | tcp: remove redundant new line from tcp_event_sk_skb (diff) | |
| download | linux-dev-40a1dcee2d1846a24619fe9ca45c661ca0db7dda.tar.xz linux-dev-40a1dcee2d1846a24619fe9ca45c661ca0db7dda.zip | |
net: ethernet: dwmac-sun8i: Use the correct function in exit path
When PHY is not powered, the probe function fail and some resource are
still unallocated.
Furthermore some BUG happens:
dwmac-sun8i 5020000.ethernet: EMAC reset timeout
------------[ cut here ]------------
kernel BUG at /linux-next/net/core/dev.c:9844!
So let's use the right function (stmmac_pltfr_remove) in the error path.
Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
Cc: <stable@vger.kernel.org> # v4.15+
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/stmicro')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index ddcc191febdb..6e47be63a43c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -1226,7 +1226,7 @@ static int sun8i_dwmac_probe(struct platform_device *pdev) dwmac_mux: sun8i_dwmac_unset_syscon(gmac); dwmac_exit: - sun8i_dwmac_exit(pdev, plat_dat->bsp_priv); + stmmac_pltfr_remove(pdev); return ret; } |