diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 13:58:22 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-09-27 10:15:11 +0200 |
| commit | f10210517a2f37feea2edf85eb34c98977265c16 (patch) | |
| tree | 919387ba25fff217362cdd03f009696fc24caa3a /drivers/net/ethernet/stmicro | |
| parent | net: socionext: Fix a signedness bug in ave_probe() (diff) | |
| download | linux-dev-f10210517a2f37feea2edf85eb34c98977265c16.tar.xz linux-dev-f10210517a2f37feea2edf85eb34c98977265c16.zip | |
net: stmmac: dwmac-meson8b: Fix signedness bug in probe
The "dwmac->phy_mode" is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.
Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/stmicro')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c index 9cda29e4b89d..306da8f6b7d5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c @@ -339,7 +339,7 @@ static int meson8b_dwmac_probe(struct platform_device *pdev) dwmac->dev = &pdev->dev; dwmac->phy_mode = of_get_phy_mode(pdev->dev.of_node); - if (dwmac->phy_mode < 0) { + if ((int)dwmac->phy_mode < 0) { dev_err(&pdev->dev, "missing phy-mode property\n"); ret = -EINVAL; goto err_remove_config_dt; |