diff options
| author |   Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> | 2019-06-15 14:01:32 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-06-16 14:03:25 -0700 |
| commit | 871e846585919adf727f21398f433fd424b6f0e1 (patch) | |
| tree | 19da3891f6595a817ddb9f1c8895a1f71aa83ec7 /drivers/net/ethernet/ti/davinci_emac.c | |
| parent | Merge branch 'stmmac-cleanups-for-stmmac_mdio_reset' (diff) | |
| download | linux-dev-871e846585919adf727f21398f433fd424b6f0e1.tar.xz linux-dev-871e846585919adf727f21398f433fd424b6f0e1.zip | |
net: ethernet: ti: davinci_cpdma: use idled submit
While data pass suspend, reuse of rx descriptors can be disabled using
channel state & lock from cpdma layer. For this, submit to a channel
has to be disabled using state != "not active" under lock, what is done
with this patch. The same submit is used to fill rx channel while
ndo_open, when channel is idled, so add idled submit routine that
allows to prepare descs for the channel. All this simplifies code and
helps to avoid dormant mode usage and send packets only to active
channels, avoiding potential race in later on changes. Also add missed
sync barrier analogically like in other places after stopping tx
queues.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/ti/davinci_emac.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index 4bf65cab79e6..5f4ece0d5a73 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -1428,8 +1428,8 @@ static int emac_dev_open(struct net_device *ndev) if (!skb) break; - ret = cpdma_chan_submit(priv->rxchan, skb, skb->data, - skb_tailroom(skb), 0); + ret = cpdma_chan_idle_submit(priv->rxchan, skb, skb->data, + skb_tailroom(skb), 0); if (WARN_ON(ret < 0)) break; } |