diff options
| author |   Robert Hancock <hancock@sedsystems.ca> | 2019-06-06 16:28:19 -0600 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-06-06 16:24:30 -0700 |
| commit | 70c50265c46b7f44823313b87e7e3a3808489c5d (patch) | |
| tree | c2fe9fce4481123c363da7d5242615f8c5137172 /drivers/net/ethernet/xilinx | |
| parent | net: axienet: Make missing MAC address non-fatal (diff) | |
| download | linux-dev-70c50265c46b7f44823313b87e7e3a3808489c5d.tar.xz linux-dev-70c50265c46b7f44823313b87e7e3a3808489c5d.zip | |
net: axienet: stop interface during shutdown
On some platforms, such as iMX6 with PCIe devices, crashes or hangs can
occur if the axienet device continues to perform DMA transfers after
parent devices/busses have been shut down. Shut down the axienet
interface during its shutdown callback in order to avoid this.
Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/xilinx')
| -rw-r--r-- | drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 6e75c4320f80..d138db8d6e7a 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1797,9 +1797,23 @@ static int axienet_remove(struct platform_device *pdev) return 0; } +static void axienet_shutdown(struct platform_device *pdev) +{ + struct net_device *ndev = platform_get_drvdata(pdev); + + rtnl_lock(); + netif_device_detach(ndev); + + if (netif_running(ndev)) + dev_close(ndev); + + rtnl_unlock(); +} + static struct platform_driver axienet_driver = { .probe = axienet_probe, .remove = axienet_remove, + .shutdown = axienet_shutdown, .driver = { .name = "xilinx_axienet", .of_match_table = axienet_of_match, |