diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 13:59:11 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-09-27 10:17:22 +0200 |
| commit | 73e211e11be86715d66bd3c9d38b3c34b05fca9a (patch) | |
| tree | 2506e70922113c09c300c9e80e0f844058ccbc90 /drivers/net/ethernet/xilinx | |
| parent | net: stmmac: dwmac-meson8b: Fix signedness bug in probe (diff) | |
| download | linux-dev-73e211e11be86715d66bd3c9d38b3c34b05fca9a.tar.xz linux-dev-73e211e11be86715d66bd3c9d38b3c34b05fca9a.zip | |
net: axienet: fix a signedness bug in probe
The "lp->phy_mode" is an enum but in this context GCC treats it as an
unsigned int so the error handling is never triggered.
Fixes: ee06b1728b95 ("net: axienet: add support for standard phy-mode binding")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/xilinx')
| -rw-r--r-- | drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 4fc627fb4d11..676006f32f91 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1762,7 +1762,7 @@ static int axienet_probe(struct platform_device *pdev) } } else { lp->phy_mode = of_get_phy_mode(pdev->dev.of_node); - if (lp->phy_mode < 0) { + if ((int)lp->phy_mode < 0) { ret = -EINVAL; goto free_netdev; } |