diff options
| author |   Mans Rullgard <mans@mansr.com> | 2019-10-18 17:56:58 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-10-19 12:18:10 -0700 |
| commit | 05908d72cc8fa39058cd9535db2833089cc3df6f (patch) | |
| tree | 1843f841bacab8758b1d3bf836810cf53521609b /drivers/net/ethernet | |
| parent | net: aquantia: add an error handling in aq_nic_set_multicast_list (diff) | |
| download | linux-dev-05908d72cc8fa39058cd9535db2833089cc3df6f.tar.xz linux-dev-05908d72cc8fa39058cd9535db2833089cc3df6f.zip | |
net: ethernet: dwmac-sun8i: show message only when switching to promisc
Printing the info message every time more than the max number of mac
addresses are requested generates unnecessary log spam. Showing it only
when the hw is not already in promiscous mode is equally informative
without being annoying.
Signed-off-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index f97a4096f8fc..ddcc191febdb 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -651,7 +651,8 @@ static void sun8i_dwmac_set_filter(struct mac_device_info *hw, } } } else { - netdev_info(dev, "Too many address, switching to promiscuous\n"); + if (!(readl(ioaddr + EMAC_RX_FRM_FLT) & EMAC_FRM_FLT_RXALL)) + netdev_info(dev, "Too many address, switching to promiscuous\n"); v = EMAC_FRM_FLT_RXALL; } |