diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2018-03-23 23:51:57 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-26 12:11:24 -0400 |
| commit | 0c29ba1b43df1eb7d8beb03fc929d2dac4c15f7e (patch) | |
| tree | c24eb97cf3a0f2eb96cfdb446f286768185cf9a3 /drivers/net/ethernet | |
| parent | ethernet: Use octal not symbolic permissions (diff) | |
| download | linux-dev-0c29ba1b43df1eb7d8beb03fc929d2dac4c15f7e.tar.xz linux-dev-0c29ba1b43df1eb7d8beb03fc929d2dac4c15f7e.zip | |
net: qualcomm: rmnet: check for null ep to avoid null pointer dereference
The call to rmnet_get_endpoint can potentially return NULL so check
for this to avoid any subsequent null pointer dereferences on a NULL
ep.
Detected by CoverityScan, CID#1465385 ("Dereference null return value")
Fixes: 23790ef12082 ("net: qualcomm: rmnet: Allow to configure flags for existing devices")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c index 38d9356ebcc4..d33988570217 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c @@ -312,6 +312,8 @@ static int rmnet_changelink(struct net_device *dev, struct nlattr *tb[], if (data[IFLA_RMNET_MUX_ID]) { mux_id = nla_get_u16(data[IFLA_RMNET_MUX_ID]); ep = rmnet_get_endpoint(port, priv->mux_id); + if (!ep) + return -ENODEV; hlist_del_init_rcu(&ep->hlnode); hlist_add_head_rcu(&ep->hlnode, &port->muxed_ep[mux_id]); |