diff options
| author |   Serhey Popovych <serhe.popovych@gmail.com> | 2018-10-09 21:21:01 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-10-15 21:40:31 -0700 |
| commit | df52eab23d703142c766ac00bdb8db19d71238d0 (patch) | |
| tree | 6e773bc9e63f98f8adafa6f188d8d814dec1437c /drivers/net/fddi/defza.c | |
| parent | Merge tag 'wireless-drivers-next-for-davem-2018-10-14' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next (diff) | |
| download | linux-dev-df52eab23d703142c766ac00bdb8db19d71238d0.tar.xz linux-dev-df52eab23d703142c766ac00bdb8db19d71238d0.zip | |
tun: Consistently configure generic netdev params via rtnetlink
Configuring generic network device parameters on tun will fail in
presence of IFLA_INFO_KIND attribute in IFLA_LINKINFO nested attribute
since tun_validate() always return failure.
This can be visualized with following ip-link(8) command sequences:
# ip link set dev tun0 group 100
# ip link set dev tun0 group 100 type tun
RTNETLINK answers: Invalid argument
with contrast to dummy and veth drivers:
# ip link set dev dummy0 group 100
# ip link set dev dummy0 type dummy
# ip link set dev veth0 group 100
# ip link set dev veth0 group 100 type veth
Fix by returning zero in tun_validate() when @data is NULL that is
always in case since rtnl_link_ops->maxtype is zero in tun driver.
Fixes: f019a7a594d9 ("tun: Implement ip link del tunXXX")
Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/fddi/defza.c')
0 files changed, 0 insertions, 0 deletions