diff options
| author |   Jason A. Donenfeld <Jason@zx2c4.com> | 2020-02-11 20:47:06 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-02-13 14:19:00 -0800 |
| commit | e0fce6f945a26d4e953a147fe7ca11410322c9fe (patch) | |
| tree | 296c4627d70ba3e8135c95c94e0222fd79aa72b2 /drivers/net/gtp.c | |
| parent | icmp: introduce helper for nat'd source address in network device context (diff) | |
| download | linux-dev-e0fce6f945a26d4e953a147fe7ca11410322c9fe.tar.xz linux-dev-e0fce6f945a26d4e953a147fe7ca11410322c9fe.zip | |
gtp: use icmp_ndo_send helper
Because gtp is calling icmp from network device context, it should use
the ndo helper so that the rate limiting applies correctly.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Harald Welte <laforge@gnumonks.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/gtp.c')
| -rw-r--r-- | drivers/net/gtp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index af07ea760b35..672cd2caf2fb 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -546,8 +546,8 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev, mtu < ntohs(iph->tot_len)) { netdev_dbg(dev, "packet too big, fragmentation needed\n"); memset(IPCB(skb), 0, sizeof(*IPCB(skb))); - icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED, - htonl(mtu)); + icmp_ndo_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED, + htonl(mtu)); goto err_rt; } |