diff options
| author |   Andrea Parri (Microsoft) <parri.andrea@gmail.com> | 2021-03-01 19:25:30 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-03-01 15:30:52 -0800 |
| commit | 3946688edbc5b629110c339b3babf10aa9e7adad (patch) | |
| tree | b72e021c1b857c4407f941010280e78d6296b573 /drivers/net/hyperv/rndis_filter.c | |
| parent | net: dsa: tag_mtk: fix 802.1ad VLAN egress (diff) | |
| download | linux-dev-3946688edbc5b629110c339b3babf10aa9e7adad.tar.xz linux-dev-3946688edbc5b629110c339b3babf10aa9e7adad.zip | |
hv_netvsc: Fix validation in netvsc_linkstatus_callback()
Contrary to the RNDIS protocol specification, certain (pre-Fe)
implementations of Hyper-V's vSwitch did not account for the status
buffer field in the length of an RNDIS packet; the bug was fixed in
newer implementations. Validate the status buffer fields using the
length of the 'vmtransfer_page' packet (all implementations), that
is known/validated to be less than or equal to the receive section
size and not smaller than the length of the RNDIS message.
Reported-by: Dexuan Cui <decui@microsoft.com>
Suggested-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Fixes: 505e3f00c3f36 ("hv_netvsc: Add (more) validation for untrusted Hyper-V values")
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/hyperv/rndis_filter.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index 123cc9d25f5e..c0e89e107d57 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -620,7 +620,7 @@ int rndis_filter_receive(struct net_device *ndev, case RNDIS_MSG_INDICATE: /* notification msgs */ - netvsc_linkstatus_callback(ndev, rndis_msg, data); + netvsc_linkstatus_callback(ndev, rndis_msg, data, buflen); break; default: netdev_err(ndev, |