aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/irda/sh_sir.c
diff options
context:
space:
mode:
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>2010-04-05 18:43:09 +0000
committerDavid S. Miller <davem@davemloft.net>2010-04-06 19:50:20 -0700
commitba5d47cf4313e86afe046d402b8cfe7b2bca911d (patch)
tree1071b74daf19dc3bac30763214306fbb743254d7 /drivers/net/irda/sh_sir.c
parentsocket: remove duplicate declaration of struct timespec (diff)
downloadlinux-dev-ba5d47cf4313e86afe046d402b8cfe7b2bca911d.tar.xz
linux-dev-ba5d47cf4313e86afe046d402b8cfe7b2bca911d.zip
net/irda: sh_sir: fixup err return value on sh_sir_open
On sh_sir_open function, there was a possibility that err variable didn't have value even though it is return value. This patch modify it. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
-rw-r--r--drivers/net/irda/sh_sir.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/irda/sh_sir.c b/drivers/net/irda/sh_sir.c
index d7c983dc91ad..761ed012f0bb 100644
--- a/drivers/net/irda/sh_sir.c
+++ b/drivers/net/irda/sh_sir.c
@@ -645,8 +645,10 @@ static int sh_sir_open(struct net_device *ndev)
sh_sir_set_baudrate(self, 9600);
self->irlap = irlap_open(ndev, &self->qos, DRIVER_NAME);
- if (!self->irlap)
+ if (!self->irlap) {
+ err = -ENODEV;
goto open_err;
+ }
/*
* Now enable the interrupt then start the queue