diff options
| author |   Florian Westphal <fw@strlen.de> | 2020-02-17 16:54:38 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-02-18 12:05:53 -0800 |
| commit | d99bfed58d9698c0ea1dbf47e4fdf4b87cc7203f (patch) | |
| tree | c577242f60d4c369f81eab6340134ce28ae955b7 /drivers/net/phy/broadcom.c | |
| parent | qede: Fix race between rdma destroy workqueue and link change event (diff) | |
| download | linux-dev-d99bfed58d9698c0ea1dbf47e4fdf4b87cc7203f.tar.xz linux-dev-d99bfed58d9698c0ea1dbf47e4fdf4b87cc7203f.zip | |
mptcp: fix bogus socket flag values
Dan Carpenter reports static checker warnings due to bogus BIT() usage:
net/mptcp/subflow.c:571 subflow_write_space() warn: test_bit() takes a bit number
net/mptcp/subflow.c:694 subflow_state_change() warn: test_bit() takes a bit number
net/mptcp/protocol.c:261 ssk_check_wmem() warn: test_bit() takes a bit number
[..]
This is harmless (we use bits 1 & 2 instead of 0 and 1), but would
break eventually when adding BIT(5) (or 6, depends on size of 'long').
Just use 0 and 1, the values are only passed to test/set/clear_bit
functions.
Fixes: 648ef4b88673 ("mptcp: Implement MPTCP receive path")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions